Changeset 3726

Timestamp:

07/23/08 13:42:24

Author:

svillar

Message:

• Properly registers camel operations
  
• Added progress information to get_headers_async call
  

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-account.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-folder.c (modified) (8 diffs)

trunk/ChangeLog

@@ +1 @@
+2008-07-23  Sergio Villar Senin  <svillar@igalia.com>
+
+        * libtinymail-camel/tny-camel-account.c
+        (_tny_camel_account_start_camel_operation_n): added a missing
+        camel_operation_register that was preventing progress info to be
+        threw up and cancelations as well.
+
+        * libtinymail-camel/tny-camel-folder.c: added progress information
+        to get_headers_async function.
+
-2008-07-21  Jose Dapena Paz  <jdapena@igalia.com>
-

trunk/libtinymail-camel/tny-camel-account.c

@@ -782 +782 @@
-        priv->cancel = camel_operation_new (func, user_data);
-
+        camel_operation_register (priv->cancel);
-        camel_operation_start (priv->cancel, (char*)what);
-

trunk/libtinymail-camel/tny-camel-folder.c

@@ -2189 +2189 @@
-        gboolean refresh;
-        TnyGetHeadersCallback callback;
+        TnyStatusCallback status_callback;
-        gpointer user_data;
-        TnySessionCamel *session;
-        gboolean cancelled;
+        TnyIdleStopper *stopper;
-
-} GetHeadersInfo;
@@ -2209 +2211 @@
-        if (info->err)
-                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
-
-        /**/
@@ -2226 +2231 @@
-                tny_lockable_unlock (info->session->priv->ui_lock);
-        }
+        tny_idle_stopper_stop (info->stopper);
+
-        return FALSE;
-}
+
+static void
+tny_camel_folder_get_headers_async_status (struct _CamelOperation *op, const char *what, int sofar, int oftotal, void *thr_user_data)
+{
+        GetHeadersInfo *oinfo = thr_user_data;
+        TnyProgressInfo *info = NULL;
+
+        info = tny_progress_info_new (G_OBJECT (oinfo->self), oinfo->status_callback, 
+                                      TNY_FOLDER_STATUS, TNY_FOLDER_STATUS_CODE_GET_MSG, what, sofar, 
+                                      oftotal, oinfo->stopper, oinfo->session->priv->ui_lock, oinfo->user_data);
+        
+        g_idle_add_full (TNY_PRIORITY_LOWER_THAN_GTK_REDRAWS, 
+                         tny_progress_info_idle_func, info, 
+                         tny_progress_info_destroy);
+        
+        return;
+}
+
-
-static gpointer 
@@ -2233 +2258 @@
-{
-        GetHeadersInfo *info = (GetHeadersInfo*) thr_user_data;
+        TnyCamelFolderPriv *priv = TNY_CAMEL_FOLDER_GET_PRIVATE (info->self);
+
-        info->err = NULL;
+        info->cancelled = FALSE;
+
+        g_static_rec_mutex_lock (priv->folder_lock);
+
+        _tny_camel_account_start_camel_operation (TNY_CAMEL_ACCOUNT (priv->account),
+                                                  tny_camel_folder_get_headers_async_status, 
+                                                  info, "Getting headers");
+
-        tny_folder_get_headers (info->self, info->headers, info->refresh, &info->err);
-
+
+
-
-        if (info->err != NULL) {
@@ -2241 +2277 @@
-                        info->cancelled = TRUE;
-        }
+
+        g_static_rec_mutex_unlock (priv->folder_lock);
-
-        return NULL;
@@ -2257 +2295 @@
-        g_object_unref (info->headers);
-
-
+
+
-
-        camel_object_unref (info->session);
@@ -2298 +2337 @@
-        info->refresh = refresh;
-        info->callback = callback;
+        info->status_callback = status_callback;
-        info->user_data = user_data;
-        info->err = NULL;
+        info->stopper = tny_idle_stopper_new();
-
-        /* thread reference */
@@ -2319 +2360 @@
-                info, sizeof (GetHeadersInfo),
-                TNY_CAMEL_QUEUE_PRIORITY_ITEM/*|TNY_CAMEL_QUEUE_CANCELLABLE_ITEM*/|
-       
+
-                __FUNCTION__);
-